If it's a hack to solve ikayzo problem, then it's perfect.
Its not a hack. I guess I didn't explain enough about our additions.
If it's aimed for long term, then (1) Why not allowing setting file name for csv, xml, svg files?
Hongbing and I designed the improvements to TemporaryFile to be able to work with CSV, XML, and SVG files. We just weren't compelled to change the other Report Views just yet, because there is no current need for it. If someone out there needs to name CSV, XML, SVG files let me know, then I will make the same improvements those views as I did for ChartView. Otherwise, I will log this in Jira and get to it later date.
(2) Shouldn't the capability of setting file names be moved to report package?
It definitely is in the hackyReport package. We've added the improvement to the ChartView in the hackyReport package. Not to mention we made a slight improvement to TemporaryFile. So, the improvements we made are very general and not a hack specifically for Ikayzo. I just didn't want to go through the trouble of changing every analysis and/or every report view if there was no reason for it. Currently our only need is for the TelemetryChartAnalysis.
As always, the analysis needs to determine what View specific parameters are needed; much like the code you added to check for the SVG report type. The code I added to your TelemetryChartAnalysis simply checks and calls the correct ChartView method. Therefore, the TelemetryChartAnalysis doesn't do anything out of the ordinary.
To conclude, I don't think its a hack. Its very general, although at the same time, its not complete.
thanks, aaron
