Hi, Christoph,

I checked your modifications.

(1) Changes in TelemetryExpressionEvaluation and
TelemetryStreamCollection are minor, and I concur with your changes.

(2) I am not sure whether changes in WorkspaceActiveTimeReducer is
necessary.

  The original logic is

  foreach workspace in a project {
    trimmedPath = workspace.getTrimmedPath();
    use "trimmedPath" as stream tag.
  }

I think no two trimmed paths can be the same in a project.

(Hongbing: can you confirm this???).

Thanks.

Cedric



Christoph Lofi wrote:
Hi all.

Sure I can explain what I did to Telemetry.
I had weird exceptions in m stuff, coming from Telemetry which didn't
make any sense.

So, in the two infrastructure classes, I changed the exception
handling so that it supports chained exception. I had these weird
exceptions, I didn't know want went wrong because Telemetry only told
me something like: "...there is a problem with telemetry..." which was
completly not helpful. So I included the causing excpetions while
throwing the TelemetryExceptions, allwoing exceptions from
TelemetryStream to work their way up  through StreamCollection and
ExpressionEvaluation to me.

After doing that, I found out that WorkspaceActiveTimeReducer had a
weird misbehaviour where it tried to re-create Streams multiple times
in secial cases with multiple workspaces which have the same trimmed
Workspacename. This caused the StreamCollection to fail when it tried
to add them (because a stream with that tag was already in). I fixed
that.
Unfortunatly, I introduced a typo which failed the Unit test (sorry,
yea, I know, that shouldn't happen.)

Christoph

On 7/11/05, Qin Zhang <[EMAIL PROTECTED]> wrote:

Hi, Christoph,

Could you let me know why you are changing the following class?
 * TelemetryExpressionEvaluation
 * TelemetryStreamCollection
 * WorkspaceActiveTimeReducer

Two of them are at telemetry infrastructure level!

Cheers,

Cedric



----- Original Message -----
From: Philip Johnson <[EMAIL PROTECTED]>
Date: Monday, July 11, 2005 6:59 am
Subject: Re: [HACKYSTAT-DEV-L] Hackystat-ALL Build Failed



--On Monday, July 11, 2005 3:33 AM -1000 [EMAIL PROTECTED] wrote:


Hackystat build (configuration Hackystat-ALL) failed.
Build report is available at


http://xenia.ics.hawaii.edu/hackyDevSite/configurationBuildReport.do?

year> =2005&month=7&day=11&configuration=Hackystat-ALL Build Time
Stamp: Mon

Jul 11 03:33:59 HST 2005

There are junit failures in hackyCGQM and hackyTelemetry.  Since
the only
commit was to hackyCGQM, I suspect that Christoph should take a
look at the
problem. :-)

Cheers,
Philip




Reply via email to