--On Sunday, March 26, 2006 12:34 AM -1000 "(Cedric) Qin ZHANG" <[EMAIL PROTECTED]> wrote:

It seems there is zero reference to this method in Core_Common. If I am
right, we'd better get rid of it. Can you confirm?

Given that DailyProjectData instances can be in _any_ module (and most commonly appear in the hackySdt_* modules), the fact that there are no references to this method in hackyCore_Common doesn't mean much.

The important design issue is whether or not we want to forbid DailyProjectData instances from containing any references to Workspaces, and (since there's no automated way to prevent this) do the code reviews necessary to prevent this from occurring. I'm not sure this is a restriction that's appropriate or necessary at this time.

If we feel that it's OK for DailyProjectData instances to contain workspaces, then this method is crucial to the correct functioning of the system. Indeed, we need to remember when writing the chapter on the design of DailyProjectData instances to tell developers that they must override this method in subclasses where Workspaces are being cached in order to maintain the correct behavior.

Cheers,
Philip

Reply via email to