Hi all,

This Tuesday (March 28, 2006) at noon in POST 307, we will review HACK-629 (CodeIssue SDT Evolution). To perform this review:

(a) Install/update the Eclipse Jupiter plugin.
(b) Install/update and enable the Hackystat Jupiter sensor.
(c) Switch to SVN branch 'branches/HACK-629'

The Jupiter Review ID "HACK-629" has been defined in two modules: hackySdt_CodeIssue and hackySensor_Checkstyle. Please review the files indicated by the Review ID in those modules. Note that hackySensor_Pmd and hackySensor_FindBugs were also modified but the changes were similar to those of hackySensor_Checkstyle so they have been excluded from this review.

I am particularly concerned about the following issues:

* Has the evolution been performed correctly? Do you feel the resulting set of required and optional fields are appropriate?

* Is the Docbook documentation for the CodeIssue SDT clear? (You might want to invoke 'ant hackyCore_Build.buildDocBook' to generate the formatted version). Do you understand the descriptions of the optional fields?

After finishing your review, please be sure to SVN commit your changes. Note that you will need to SVN 'add' your files (and potentially the review/ directory) before doing the commit.

---------------------------------------
Supplemental links and resources

The Hackystat Code Review Guidelines:
* http://hackydev.ics.hawaii.edu/hackyDevSite/doc/Review.html

The Elements of Hacky Style:
* http://hackydev.ics.hawaii.edu/hackyDevSite/doc/EHS.html

Jupiter Code Review Tool documentation:
* http://csdl.ics.hawaii.edu/Tools/Jupiter/Core/doc/UsersGuide.html

----------------------------------------

Thanks for reviewing the code!

Julie

Reply via email to