Under rare cases, telemetry module does generate duplicated series name
depending on the particular definition and user input. It's better to
allow duplicated names than arbitrary change those names.
Glad to know the underlying JFreeChart can handle duplicated names. I'll
work on it after I finish dealing with telemetry model.
Cheers,
Cedric
Hongbing Kou wrote:
Hi, Cedric,
I think it is reasonable to disallow identical series name in chart
because you will not be able to tell which line is for which series if
two of them are identical. For instance, the project member active
time series must have developer's ID or email attached to distinguish
category series on active time.
I remember the restriction is on hackyCore_Report. If you really want
same series name and there is good justification you can go ahead to
change the internal implementation of CategoryDataModel. I think there
will not have other ripple effects once all unit tests pass.
Thanks,
Hongbing
(Cedric) Qin ZHANG wrote:
Hi, Philip and Hongbing,
I am cleaning Core_Telemetry code and there is some workaround I
really want to get rid of.
Current CategoryDataModel blows up when you add more than one
CategorySeries with the same name. I have to use pretty arbitrary
workaround by adding stars to category name in case of duplication.
I am not sure whether this is a restriction in JFreeChart or
Core_Report. My understanding is this is caused by
CategoryDataModel's internal use of Map and keys CategorySeries by
name. If I am right, then it won't be hard to remove this restriction.
Thanks,
Cedric
