Line 87.
StringTokenizer tokenizer = new StringTokenizer(dataString, ",");
StringTokenizer is old stuff. Use String.split instead.
Thanks, Aaron
At 11:19 AM 3/24/2006, you wrote:
Greetings, folks,
This Monday (March 27, 2006) at noon in POST 307, we will review HACK-631 (ReviewActivity SDT Evolution). To perform this review:
(a) Install/update the Eclipse Jupiter plugin.
(b) Install/update and enable the Hackystat Jupiter sensor.
(c) Switch to SVN branch 'branches/HACK-631'
The Jupiter Review ID "HACK-631" has been defined in two modules: hackySdt_ReviewActivity and hackySensor_Jupiter. Please review the files indicated by the Review ID in those modules.
I am particularly concerned about the following issues:
* Has the evolution been performed correctly? Do you feel the resulting set of required and optional fields are appropriate?
* Is the Docbook documentation for the ReviewActivity SDT clear? (You might want to invoke 'ant hackyCore_Build.buildDocBook' to generate the formatted version).
After finishing your review, please be sure to SVN commit your changes. Note that you will need to SVN 'add' your files (and potentially the review/ directory) before doing the commit.
---------------------------------------
Supplemental links and resources
The Hackystat Code Review Guidelines:
* http://hackydev.ics.hawaii.edu/hackyDevSite/doc/Review.html
The Elements of Hacky Style:
* http://hackydev.ics.hawaii.edu/hackyDevSite/doc/EHS.html
Jupiter Code Review Tool documentation:
* http://csdl.ics.hawaii.edu/Tools/Jupiter/Core/doc/UsersGuide.html
----------------------------------------
Thanks for reviewing the code!
Philip
