Hi, Philip,
Why we have to put them together? Why not having two types of daily
project objects, one for telemetry style analysis, one for daily project
details style analysis. My 2 cents.
This is an interesting question. We should look into this further,
and figure out whether:
(a) DailyProjectDetails and Telemetry have no way in principle to
share caching mechanisms, and the code would be clearer as two
distinct classes.
(b) The current separation is an artifact of different people working
on this code at different times. A redesign of this class might show
opportunities to share code/infrastructure
Actually Cedric already did good job to make code clean and reuse.
Before I made the change on DailyProjectUnitTest, telemetry and
getDrillDown both use FilePattern match mechanism. The lesson is that
converting project's workspace to FilePattern to reuse telemetry code
brings performance regression.
Thanks,
Hongbing
