svn commit: r539089 - in /lucene/hadoop/trunk: CHANGES.txt src/java/org/apache/hadoop/mapred/lib/aggregate/ValueHistogram.java src/test/org/apache/hadoop/mapred/TestAggregates.java

[cutting]

Author: cutting
Date: Thu May 17 12:50:06 2007
New Revision: 539089

URL: http://svn.apache.org/viewvc?view=rev&rev=539089
Log:
HADOOP-1356.  Fix a bug in ValueHistogram.  Contributed by Runping.

Modified:
    lucene/hadoop/trunk/CHANGES.txt
    
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/lib/aggregate/ValueHistogram.java
    lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestAggregates.java

Modified: lucene/hadoop/trunk/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?view=diff&rev=539089&r1=539088&r2=539089
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Thu May 17 12:50:06 2007
@@ -417,6 +417,8 @@
 116. HADOOP-1358.  Fix a potential bug when DFSClient calls skipBytes.
      (Hairong Kuang via cutting)
 
+117. HADOOP-1356.  Fix a bug in ValueHistogram.  (Runping Qi via cutting)
+
 
 Release 0.12.3 - 2007-04-06
 

Modified: 
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/lib/aggregate/ValueHistogram.java
URL: 
http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/lib/aggregate/ValueHistogram.java?view=diff&rev=539089&r1=539088&r2=539089
==============================================================================
--- 
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/lib/aggregate/ValueHistogram.java
 (original)
+++ 
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/lib/aggregate/ValueHistogram.java
 Thu May 17 12:50:06 2007
@@ -51,7 +51,7 @@
     String valStr = valCountStr;
     String countStr = "1";
     if (pos >= 0) {
-      valCountStr.substring(0, pos);
+      valStr = valCountStr.substring(0, pos);
       countStr = valCountStr.substring(pos + 1);
     }
     

Modified: 
lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestAggregates.java
URL: 
http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestAggregates.java?view=diff&rev=539089&r1=539088&r2=539089
==============================================================================
--- lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestAggregates.java 
(original)
+++ lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestAggregates.java 
Thu May 17 12:50:06 2007
@@ -108,6 +108,8 @@
     boolean success = true;
     Path outPath = new Path(OUTPUT_DIR, "part-00000");
     String outdata = TestMiniMRWithDFS.readOutput(outPath,job);
+    System.out.println("full out data:");
+    System.out.println(outdata.toString());
     outdata = outdata.substring(0, expectedOutput.toString().length());
 
     assertEquals(expectedOutput.toString(),outdata);