Author: tomwhite
Date: Tue May 22 01:29:54 2007
New Revision: 540469
URL: http://svn.apache.org/viewvc?view=rev&rev=540469
Log:
Fix integer division bug in JobInProgress which meant failed tasks didn't cause
the job to fail. Contributed by Arun C Murthy.
Modified:
lucene/hadoop/trunk/CHANGES.txt
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java
Modified: lucene/hadoop/trunk/CHANGES.txt
URL:
http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?view=diff&rev=540469&r1=540468&r2=540469
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Tue May 22 01:29:54 2007
@@ -462,6 +462,10 @@
force applications to use "." to name the default directory.
(Hairong Kuang via cutting)
+125. HADOOP-1407. Fix integer division bug in JobInProgress which
+ meant failed tasks didn't cause the job to fail.
+ (Arun C Murthy via tomwhite)
+
Release 0.12.3 - 2007-04-06
Modified:
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java
URL:
http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java?view=diff&rev=540469&r1=540468&r2=540469
==============================================================================
--- lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java
(original)
+++ lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java
Tue May 22 01:29:54 2007
@@ -943,8 +943,8 @@
//
boolean killJob =
tip.isMapTask() ?
- (((++failedMapTIPs*100)/numMapTasks) > mapFailuresPercent) :
- (((++failedReduceTIPs*100)/numReduceTasks) >
reduceFailuresPercent);
+ ((++failedMapTIPs*100) > (mapFailuresPercent*numMapTasks)) :
+ ((++failedReduceTIPs*100) >
(reduceFailuresPercent*numReduceTasks));
if (killJob) {
LOG.info("Aborting job " + profile.getJobId());
