Author: enis
Date: Fri Jan 18 01:51:16 2008
New Revision: 613115

URL: http://svn.apache.org/viewvc?rev=613115&view=rev
Log:
HADOOP-2538.  Redirect to a warning, if plaintext parameter is true but the 
filter parameter is not given in TaskLogServlet.  Contributed by Michael 
Bieniosek. 


Modified:
    lucene/hadoop/trunk/CHANGES.txt
    lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/TaskLogServlet.java

Modified: lucene/hadoop/trunk/CHANGES.txt
URL: 
http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?rev=613115&r1=613114&r2=613115&view=diff
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Fri Jan 18 01:51:16 2008
@@ -506,6 +506,10 @@
     HADOOP-290. A DataNode log message now prints the target of a replication
     request correctly. (dhruba)
 
+    HADOOP-2538. Redirect to a warning, if plaintext parameter is true but 
+    the filter parameter is not given in TaskLogServlet.  
+    (Michael Bieniosek via enis)
+
 Release 0.15.3 - 2008-01-18
 
   BUG FIXES

Modified: 
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/TaskLogServlet.java
URL: 
http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/TaskLogServlet.java?rev=613115&r1=613114&r2=613115&view=diff
==============================================================================
--- lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/TaskLogServlet.java 
(original)
+++ lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/TaskLogServlet.java 
Fri Jan 18 01:51:16 2008
@@ -140,6 +140,9 @@
       
       out.write("</body></html>\n".getBytes());
       out.close();
+    } else if (filter == null) {
+      response.sendError(HttpServletResponse.SC_BAD_REQUEST,
+          "You must supply a value for `filter' (STDOUT, STDERR, or SYSLOG) if 
you set plainText = true");
     } else {
       printTaskLog(response, out, taskId, start, end, plainText, filter);
     } 


Reply via email to