[ http://issues.apache.org/jira/browse/HADOOP-151?page=all ]
Doug Cutting resolved HADOOP-151:
---------------------------------
Resolution: Fixed
I just fixed this. I restored the original behaviour, where a single client is
used for all calls, regardless of the configuration. This results in the use
of a single connection pool for all RPC calls, and hence closes a potential
socket leak. Long-term we might consider other approaches to pooling
connections. Today it seemed more important to close the leak than to, e.g.,
permit different ipc timeouts for different jobs.
> RPC code has socket leak?
> -------------------------
>
> Key: HADOOP-151
> URL: http://issues.apache.org/jira/browse/HADOOP-151
> Project: Hadoop
> Type: Bug
> Components: ipc
> Versions: 0.1.0, 0.2, 0.1.1
> Reporter: paul sutter
> Assignee: Doug Cutting
> Fix For: 0.2
>
> In RPC.java, the field named CLIENT should be neither static, nor a field of
> RPC. It should be (a) a private nonstatic field of InvocationHandler(),and
> (just further down), (b) a local variable in the RPC.call() method below.
> The comment above the declaration was a bit of giveaway:
> //TODO [EMAIL PROTECTED]: static client or non-static client?
> private static Client CLIENT;
> private static class Invoker implements InvocationHandler {
> private InetSocketAddress address;
> public Invoker(InetSocketAddress address, Configuration conf) {
> this.address = address;
> CLIENT = (Client) conf.getObject(Client.class.getName());
> if(CLIENT == null) {
> CLIENT = new Client(ObjectWritable.class, conf);
> conf.setObject(Client.class.getName(), CLIENT);
> }
> }
> public Object invoke(Object proxy, Method method, Object[] args)
> throws Throwable {
> ObjectWritable value = (ObjectWritable)
> CLIENT.call(new Invocation(method, args), address);
> return value.get();
> }
> }
> /** Construct a client-side proxy object that implements the named protocol,
> * talking to a server at the named address. */
> public static Object getProxy(Class protocol, InetSocketAddress addr,
> Configuration conf) {
> return Proxy.newProxyInstance(protocol.getClassLoader(),
> new Class[] { protocol },
> new Invoker(addr, conf));
> }
> /** Expert: Make multiple, parallel calls to a set of servers. */
> public static Object[] call(Method method, Object[][] params,
> InetSocketAddress[] addrs, Configuration conf)
> throws IOException {
> Invocation[] invocations = new Invocation[params.length];
> for (int i = 0; i < params.length; i++)
> invocations[i] = new Invocation(method, params[i]);
> CLIENT = (Client) conf.getObject(Client.class.getName());
> if(CLIENT == null) {
> CLIENT = new Client(ObjectWritable.class, conf);
> conf.setObject(Client.class.getName(), CLIENT);
> }
> Writable[] wrappedValues = CLIENT.call(invocations, addrs);
>
> if (method.getReturnType() == Void.TYPE) {
> return null;
> }
> Object[] values =
>
> (Object[])Array.newInstance(method.getReturnType(),wrappedValues.length);
> for (int i = 0; i < values.length; i++)
> if (wrappedValues[i] != null)
> values[i] = ((ObjectWritable)wrappedValues[i]).get();
>
> return values;
> }.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
