[ http://issues.apache.org/jira/browse/HADOOP-226?page=comments#action_12412282 ]
Konstantin Shvachko commented on HADOOP-226: -------------------------------------------- I like Commons CLI. I think we should use it. Except that we have sort of just one command, which is hadoop, with hierarchical options, arguments, and sub-options. Yes HADOOP-59 has other related issues. I agree we should combine all of them in one new issue specifically dedicated to DFSShell. > DFSShell problems. Incorrect block replication detection in fsck. > ----------------------------------------------------------------- > > Key: HADOOP-226 > URL: http://issues.apache.org/jira/browse/HADOOP-226 > Project: Hadoop > Type: Bug > Components: dfs > Environment: All > Reporter: Konstantin Shvachko > > 1. We need to adjust Dfsck to the new per-file replication feature. > fsck checks block replication based on the configured global replication > parameter. > Which is now just the default. The actual file replication is returned in > DFSFileInfo. > So at least the reporting is screwed by that, although I didn't check what > will happen with > other options -move and -delete. > 2. fsck throws NullPointerException if you type > bin/hadoop fsck -files /doc > instead of > bin/hadoop fsck /doc -files > 3. Unfortunately, there are several commands that throw different kinds of > Exceptions > rather than at least printing the usage info, when some of its arguments are > missing or > misplaced. ArrayIndexOutOfBoundsException is one them. Try > bin/hadoop dfs -mv > bin/hadoop dfs -cp > bin/hadoop dfs -rm > 4. In general the shell is growing and getting more sophisticated. > Should we work out a general convention on how the parameters should be > structured, named, > short/long version of the keywords, help, etc. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
