[ 
http://issues.apache.org/jira/browse/HADOOP-196?page=comments#action_12420572 ] 

Doug Cutting commented on HADOOP-196:
-------------------------------------

> Is there a reason why the patch was not submitted?

Not a good one.  I think it just fell off my radar.

It would be good to add a unit test for this.  I think the use case is roughly:

Configuration c1 = new Configuration();
c1.set("foo", "bar");
Configuratoin c2 = new Configuration(c1);
assertEquals(c2.get("foo"), "bar");

Is that right?

The provided patch would fix this, but by setting all the values except "foo" 
twice: once when reloaded from resources and once when reloaded from overrides. 
 Perhaps it would be better to put all resource-loaded properties in a nested 
Properties instance that's inherited via 'new Properties(Properties)' and only 
store values set directly in a top-level Properties instance.  Or perhaps we 
should just set most of the values twice and not worry about it.  Thoughts, 
anyone?

> Fix buggy uselessness of Configuration( Configuration other) constructor
> ------------------------------------------------------------------------
>
>          Key: HADOOP-196
>          URL: http://issues.apache.org/jira/browse/HADOOP-196
>      Project: Hadoop
>         Type: Bug

>   Components: conf
>     Reporter: alan wootton
>  Attachments: ConfigConstructorFix.patch
>
> The constructor 
> public Configuration(Configuration other) 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to