[ http://issues.apache.org/jira/browse/HADOOP-237?page=comments#action_12421035 ]
Doug Cutting commented on HADOOP-237: ------------------------------------- I still feel the duplicate could should be removed. Performance should not motivate this: HotSpot should be able to inline regardless. Nearly identical code is repeated in eight places, differing only in a constant string, which can easily be made a paramter. If local modifications are required, then the common implementation can be subclassed or not used, but currently there are effectively no local modifications. Also, you're still ignoring rather than logging exceptions. This code will become the prototypical use of the metrics API. We should make sure that it looks good. If boilerplate code is required for prototypical use, then that boilerplate should become utility methods and/or classes in the metrics package, and the metrics package-level javadoc should encourage this use. Insertion of metrics code should be minimally invasive. > Standard set of Performance Metrics for Hadoop > ---------------------------------------------- > > Key: HADOOP-237 > URL: http://issues.apache.org/jira/browse/HADOOP-237 > Project: Hadoop > Type: Improvement > Components: metrics > Versions: 0.3.0 > Environment: All > Reporter: Milind Bhandarkar > Assignee: Milind Bhandarkar > Attachments: hadoop-metrics.patch > > I am starting to use Hadoop's shiny new Metrics API to publish performance > (and other) Metrics of running jobs and other daemons. > Which performance metrics are people interested in seeing ? If possible, > please group them according to modules, such as map-reduce, dfs, > general-cluster-related etc. I will follow this process: > 1. collect this list > 2. assess feasibility of obtaining metric > 3. assign context/record/metrics names > 4. seek approval for names > 5. instrument the code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
