[ http://issues.apache.org/jira/browse/HADOOP-54?page=comments#action_12424146 ] Owen O'Malley commented on HADOOP-54: -------------------------------------
I'm not set on the name nextRaw, but I think the semantics are different enough that it deserves a different name, but whatever people want. I think the 3 Writer classes should be public, because they are actually doing different things and will likely end up with different parameter lists on the constructors. I'd hate to make the factory take the super set of all parameters that any of the Writers want. ValueBytes is fine. I wasn't really intending to create a RawValue/ValueBytes for each iteration and your interface makes that clearer, so I like that. *smile* > SequenceFile should compress blocks, not individual entries > ----------------------------------------------------------- > > Key: HADOOP-54 > URL: http://issues.apache.org/jira/browse/HADOOP-54 > Project: Hadoop > Issue Type: Improvement > Components: io > Affects Versions: 0.2.0 > Reporter: Doug Cutting > Assigned To: Arun C Murthy > Fix For: 0.5.0 > > Attachments: VIntCompressionResults.txt > > > SequenceFile will optionally compress individual values. But both > compression and performance would be much better if sequences of keys and > values are compressed together. Sync marks should only be placed between > blocks. This will require some changes to MapFile too, so that all file > positions stored there are the positions of blocks, not entries within > blocks. Probably this can be accomplished by adding a > getBlockStartPosition() method to SequenceFile.Writer. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
