[ http://issues.apache.org/jira/browse/HADOOP-462?page=comments#action_12442720 ] Doug Cutting commented on HADOOP-462: -------------------------------------
Overall, this looks like a good change. In DFSShell.run(), instead of adding a 'exitCode=0' to every clause, why not change the 'else' clause to 'return -1'? That would save about 15 lines. Why the double-semicolons? And the 'else' clause you add is formatted non-standardly. There's a typo in the javadoc for setQuietMode(). > DFSShell throws out arrayoutofbounds exceptions if the number of arguments is > not right > --------------------------------------------------------------------------------------- > > Key: HADOOP-462 > URL: http://issues.apache.org/jira/browse/HADOOP-462 > Project: Hadoop > Issue Type: Bug > Components: dfs > Reporter: Mahadev konar > Assigned To: dhruba borthakur > Priority: Minor > Attachments: dfsshell.patch > > > All the DFSShell commands do not check for the number of arguments. In > DFSShell.run(), the args length is not checked before calling copyfromlocal, > movefromlocal, copytolocal, and some others as well. This throws out > arrrayoutofbounds exception in case lesser number of arguments is specified. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
