[ http://issues.apache.org/jira/browse/HADOOP-432?page=comments#action_12457043 ] Konstantin Shvachko commented on HADOOP-432: --------------------------------------------
- getDescendents(String src) { ArrayList strs = new ArrayList(); type ArrayList<E> should be parameterized - hadoop-default.xml = description for dfs.trash.trigger.size.pct should say something like "Triggers garbage collection of the expired items." = Typo emtries: should be entries - I think we should have a junit test for the feature. I'm sure you ran some programs to test the functionality. It would be nice to combine them as a test module that would ensure that future changes don't break the trash logic. > support undelete, snapshots, or other mechanism to recover lost files > --------------------------------------------------------------------- > > Key: HADOOP-432 > URL: http://issues.apache.org/jira/browse/HADOOP-432 > Project: Hadoop > Issue Type: Improvement > Components: dfs > Reporter: Yoram Arnon > Assigned To: Wendy Chien > Attachments: undelete12.patch, undelete16.patch > > > currently, once you delete a file it's gone forever. > most file systems allow some form of recovery of deleted files. > a simple solution would be an 'undelete' command. > a more comprehensive solution would include snapshots, manual and automatic, > with scheduling options. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira