[ 
https://issues.apache.org/jira/browse/HADOOP-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465622
 ] 

Milind Bhandarkar commented on HADOOP-735:
------------------------------------------

I think throwing IOException in the rest of the read* methods (even if one is 
reading from byte[]) is the right thing to do. If there are performance 
implications of doing an explicit length check, I could remove the explicit 
checkLength call, and replace it by try-catch, and throw an IOException on 
catching ArrayIndexOutOfBounds exception. This will still have some performance 
implications, but it will be smaller than an explicit method call and bounds 
check.

> The underlying data structure, ByteArrayOutputStream,  for buffer type of 
> Hadoop record is inappropriate
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-735
>                 URL: https://issues.apache.org/jira/browse/HADOOP-735
>             Project: Hadoop
>          Issue Type: Bug
>          Components: record
>    Affects Versions: 0.9.2
>            Reporter: Runping Qi
>         Assigned To: Milind Bhandarkar
>             Fix For: 0.11.0
>
>         Attachments: BytesWritable.patch
>
>
> With ByteArrayOutputStream as the underlying data structure for a buffer, the 
> user is forced to convert it into a byte [] object in order to do any 
> operations other than sequence append on the buffer. The convertion will 
> create a new copy of bytes. That will cause huge performance problem. 
> It seems BytesWritable is a better replacement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to