I wonder if the Block equals and hashCode methods are not behaving as expected. Perhaps Block.blkid and Block.len should be declared volatile.

On Jan 20, 2007, at 12:18 PM, Raghu Angadi (JIRA) wrote:


[ https://issues.apache.org/jira/browse/HADOOP-803? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel#action_12466275 ]

Raghu Angadi commented on HADOOP-803:
-------------------------------------


This is pretty weird. Both NPE and SmallBlock test failures in HADOOP-898 are caused by the same problem : node.getBlock(blockId) returns null sometimes. But I verified that node.blocks contains this block earlier and right after this failure. Any ideas?

blocks map in DatanodeDescrptor is changed like this :
-  private volatile Collection<Block> blocks = new TreeSet<Block>();
+ private volatile SortedMap<Block, Block> blocks = new TreeMap<Block, Block>();

and getBlock(long blockid) is defined as :
{  return blocks.get( new Block(blockId, 0) );  }



Reducing memory consumption on Namenode : Part 1
------------------------------------------------

                Key: HADOOP-803
                URL: https://issues.apache.org/jira/browse/HADOOP-803
            Project: Hadoop
         Issue Type: Bug
         Components: dfs
           Reporter: Raghu Angadi
        Assigned To: Raghu Angadi
            Fix For: 0.11.0

Attachments: block-refs-2.patch, block-refs-3.patch, block- refs-5.patch, HADOOP-803.patch


There appears to be some places in Namenode that allow reducing memory consumption without intrusive code or feature changes. This bug is an initial attempt making those changes. Please include your thoughts as well.
One change I am planning to make :
Currently one copy of each block exists for each of the replicas and one copy for blockMap. I think they are all supposed to be same.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/ Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/ software/jira



Reply via email to