[
https://issues.apache.org/jira/browse/HADOOP-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466632
]
navychen commented on HADOOP-405:
---------------------------------
we checked these two copies of browseDirectory.jsp and found these difference:
1. "dfs/browseDirectory.jsp": if the input is a document, the page will be
sent to "browseBlock.jsp" directly. Otherwise, the links of sub-files will be
displayed.
"datanode/browseDirectory.jsp": if the input is a document, the page will
be returned. Otherwise, the links of sub-files will be displayed.
2. All the inputs of the two pages are the same.
3. All the pages work well in our cluster. We use "dfs/browseDirectory.jsp" in
fact.
4, "dfs/browseDirectory.jsp" is a newest version than
"datanode/browseDirectory.jsp"
5, "datanode/browseDirectory.jsp" is not changed from 0.7.x or early to 0.10.x
6, "dfs/browseDirectory.jsp" is change from 0.9 and before 0.9 version of
hadoop it is completeness same as "datanode/browseDirectory.jsp"
7, hadoop actually build the "dfs/browseDirectory.jsp" to
"build/src/org/apache/hadoop/dfs/browseDirectory_jsp.java", and dosen't compile
"datanode/browseDirectory.jsp" yet
8, so we may remove "datanode/browseDirectory.jsp"
Here is our solution for HADOOP-405
1, remove "src/webapps/datanode/browseDirectory.jsp" file
2, remove line "<copy file="${src.webapps}/datanode/browseDirectory.jsp"
todir="${src.webapps}/dfs/"/>" in build.xml
We checked it worked okay, maybe remove file has a little risk, but I think it
maybe a good way for 405, isn't it?
by navychen & weilei
> Duplicate browseDirectory.jsp
> -----------------------------
>
> Key: HADOOP-405
> URL: https://issues.apache.org/jira/browse/HADOOP-405
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.4.0
> Reporter: Konstantin Shvachko
> Assigned To: Sameer Paranjpye
> Priority: Minor
>
> I found 2 identical files
> src\webapps\datanode\browseDirectory.jsp
> and
> src\webapps\dfs\browseDirectory.jsp
> And there is a line in build.xml that makes the copy
> <copy file="${src.webapps}/datanode/browseDirectory.jsp"
> todir="${src.webapps}/dfs/"/>
> That does not seem right. If one of them is a copy of another, then only one
> should be in svn.
> Another thing is that while copying files to the build/ directory is OK,
> copying files around within
> the source directories makes things complicated. Is there a way to avoid that?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
