[
https://issues.apache.org/jira/browse/HADOOP-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Cutting updated HADOOP-948:
--------------------------------
Status: Open (was: Patch Available)
This purports to improve the style, yet it does not conform to Hadoop's stated
style guidelines. In particular, Hadoop prefers code that indents two spaces
per level, and this patch adds new code that indents four-spaces per level.
> Coding style issues
> --------------------
>
> Key: HADOOP-948
> URL: https://issues.apache.org/jira/browse/HADOOP-948
> Project: Hadoop
> Issue Type: Bug
> Components: metrics
> Reporter: David Bowen
> Priority: Minor
> Attachments: hadoop-948.patch
>
>
> I would like to recommend some mainly stylistic changes in the recent fix of
> http://issues.apache.org/jira/browse/HADOOP-886. The file in question is
> CodeFactory.java, and the reasons for the changes are:
> * It is generally preferable to avoid multiple return statements.
> * It is nearly always preferable to use curly braces and a newline after
> an if (condition).
> * There's no benefit to doing the hash lookup twice in the common case (by
> calling contains and then get).
> (1) and (2) are commonly found in Java coding style guidelines as they make
> the code more readable.
> I'll attach the fix shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
