[ https://issues.apache.org/jira/browse/HADOOP-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476049 ]
Hairong Kuang commented on HADOOP-928: -------------------------------------- OK, I will keep FSInputChecker and FSOutputSummer private within ChecksumFileSystem so far. As for setting bufferSize in ChecksumFileSystem#create(Path, int bufferSize) and ChecksumFileSystem#open(Path, int bufferSize), the reason that I set the inner buffer very small is to by-pass the inner buffer and hence avoid one more data copy. > make checksums optional per FileSystem > -------------------------------------- > > Key: HADOOP-928 > URL: https://issues.apache.org/jira/browse/HADOOP-928 > Project: Hadoop > Issue Type: Improvement > Components: fs > Reporter: Doug Cutting > Assigned To: Hairong Kuang > Attachments: checksum.patch, checksum1.patch > > > Checksumming is currently built into the base FileSystem class. It should > instead be optional, with each FileSystem implementation electing whether to > use the Hadoop-provided checksum system, or to disable it, or to implement > its own custom checksum system. > To implement this, a ChecksumFileSystem implementation can be provided that > wraps another FileSystem implementation, implementing checksums as in > Hadoop's current mandatory implementation (i.e., as a separate crc file per > file that's elided from directory listings). The 'raw' FileSystem methods > would be removed. FSDataInputStream and FSDataOutputStream would be made > interfaces. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.