[
https://issues.apache.org/jira/browse/HADOOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12476249
]
Doug Cutting commented on HADOOP-1041:
--------------------------------------
> If you reread my first comment I think you'll find nothing more than simple
> code that solves the immediate problem.
Yes, it solves the problem for counters that make it into the resource file,
but not for those that don't. Thus I think grouping by enum class is required
to make it so that user counters (that would have not been added to the global
presentation resource) still look decent. Folks should be able to simply
increment a counter in their code and have something reasonable displayed in
the web interface, without reconfiguring and restarting the jobtracker. Once
we've grouped by enum class, so that the class name need not be displayed with
each counter, the incremental benefit of a separate resource is greatly
diminished. Internationalization is beyond the scope of the current issue.
> Counter names are ugly
> ----------------------
>
> Key: HADOOP-1041
> URL: https://issues.apache.org/jira/browse/HADOOP-1041
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Affects Versions: 0.12.0
> Reporter: Owen O'Malley
> Fix For: 0.12.0
>
>
> Having the complete class name in the counter names makes them unique, but
> they are ugly to present to non-developers. It would be nice to have some way
> to have a nicer string presented to the user. Currently, the Enum is
> converted to a name like:
> key.getDeclaringClass().getName() + "#" + key.toString()
> which gives counter names like
> "org.apache.hadoop.examples.RandomWriter$Counters#BYTES_WRITTEN"
> which is unique, but not very user friendly. Perhaps, we should strip off the
> class name for presenting to the users, which would allow them to make nice
> names. In particular, you could define an enum type that overloaded toString
> to print a nice user friendly string.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
