To Owen's -1:

I dislike adding sleep statements too, but 2 of these very small sleeps are a temporary necessary evil while we wait for the issues Konstantin mentioned plus HADOOP-1085. The 3rd sleep (in TestDFSFinalize) is necessary due to the architecture of the feature being tested. Yes, these can and should be revisited once the other patches are committed, but I don't think they're blockers for committing this patch.

What may be a blocker is the fact that the 5 new unit tests (totaling 134 test cases) in this patch add 19 minutes to the unit test run.

On Mar 21, 2007, at 4:22 PM, Owen O'Malley (JIRA) wrote:


[ https://issues.apache.org/jira/browse/HADOOP-702? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel#action_12482961 ]

Owen O'Malley commented on HADOOP-702:
--------------------------------------

-1

I strongly dislike adding sleep statements to the test. Please add proper synchronization to remove the need for sleeping.

DFS Upgrade Proposal
--------------------

                Key: HADOOP-702
                URL: https://issues.apache.org/jira/browse/HADOOP-702
            Project: Hadoop
         Issue Type: New Feature
         Components: dfs
           Reporter: Konstantin Shvachko
        Assigned To: Konstantin Shvachko
            Fix For: 0.13.0

Attachments: DFSUpgradeProposal3.html, FSStateTransition.patch, FSStateTransition6.htm, TestPlan- HdfsUpgrade.html, TestPlan-HdfsUpgrade.html, TestPlan- HdfsUpgrade.html


Currently the DFS cluster upgrade procedure is manual.
http://wiki.apache.org/lucene-hadoop/Hadoop_Upgrade
It is rather complicated and does not guarantee data recoverability in case of software errors or administrator mistakes. This is a description of utilities that make the upgrade process almost automatic and minimize chance of loosing or corrupting data.
Please see the attached html file for details.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply via email to