[ 
https://issues.apache.org/jira/browse/HADOOP-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483593
 ] 

Tom White commented on HADOOP-1148:
-----------------------------------

+1

My feeling is that we should fix compile warnings (HADOOP-958) before fixing 
style warnings. However, this one is relatively unobtrusive, since there is a 
way of not invalidating current patches, so I would be happy for it to go 
before or in parallel with fixing warnings.

The checkstyle build target will check identation (as well as lots of other 
things), and I would encourage developers and committers to use it, especially 
for large chunks of new code. (I should confess at this point that I have yet 
to start using it in earnest as a part of the commit cycle!)

 

> re-indent all code
> ------------------
>
>                 Key: HADOOP-1148
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1148
>             Project: Hadoop
>          Issue Type: Improvement
>            Reporter: Doug Cutting
>         Assigned To: Doug Cutting
>            Priority: Minor
>
> We should re-indent all code to consistently use 2-spaces per level.  This 
> will not invalidate outstanding patches: one can use the '-l' option to 
> ignore whitespace differences in patches.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to