if a series of patches like this one are committed, is it OK to do them all under one Jira issue?

As long as they all make it in a single release, this is fine with me. In theory we can even map issues to multiple releases, each in which they're partially fixed, but that could get confusing and I find it simpler when the set of issues in subsequent releases are disjoint.

Should we try to do all code format changes in a series of contiguous patches? This should minimize the amount of pain while diff'ing source files across revisions. Also, should these format changes be the last patches applied before a release or the first patches applied after a release?


On Mar 26, 2007, at 1:30 PM, Doug Cutting (JIRA) wrote:


[ https://issues.apache.org/jira/browse/HADOOP-958? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel#action_12484219 ]

Doug Cutting commented on HADOOP-958:
-------------------------------------

if a series of patches like this one are committed, is it OK to do them all under one Jira issue?

As long as they all make it in a single release, this is fine with me. In theory we can even map issues to multiple releases, each in which they're partially fixed, but that could get confusing and I find it simpler when the set of issues in subsequent releases are disjoint.

Building Hadoop results in a lot of warnings
--------------------------------------------

                Key: HADOOP-958
                URL: https://issues.apache.org/jira/browse/HADOOP-958
            Project: Hadoop
         Issue Type: Improvement
           Reporter: eric baldeschwieler
        Attachments: example-warnings.patch, fs-unchecked.patch


We are getting hundreds of warnings right now. Most of these are a result of our transition to 1.5 and deprecated uses of generics. We should still fix these, since producing lots of warnings:
A) Leads to the perception that our code is of low quality
B) Can mask warnings that come from real issues.
---
I suggest we do two things
1) Submit a patch or set of patches to clean this up
2) Change our patch tester to validate that the number of warnings per build did not go up with this patch

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply via email to