[ 
https://issues.apache.org/jira/browse/HADOOP-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486759
 ] 

Owen O'Malley commented on HADOOP-1001:
---------------------------------------

This looks like a reasonable approach. Please put the patches together into a 
single patch.

In the future, to facilitate this kind of testing in the future, we probably 
should add to the LocalJobRunner:

/**
* Get the exception that killed the job.
* @return The Throwable that killed the job or null if the the job was not 
killed by an exception.
*/
public static Throwable getJobException(String jobId);

Adding a field to the LocalJobRunner.Job to hold the Throwable and setting it 
with the caught exception should be easy.

Then your test could actually check the exception that was throw to see if it 
was the right type & message.

> the output of the map is not type checked against the specified types
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-1001
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1001
>             Project: Hadoop
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.11.0
>            Reporter: Owen O'Malley
>         Assigned To: Tahir Hashmi
>             Fix For: 0.13.0
>
>         Attachments: 1001.patch, 1001.patch, 1001.patch, 
> TestMapOutputType.java, TestMapOutputType.java
>
>
> The output of the map is not checked against the types specified in the 
> JobConf leading to hard to diagnose bugs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to