Ok, I'll link them off of
http://wiki.apache.org/lucene-hadoop/HowToContribute
and close this issue.

Should a +1 code review comment be required
a) before "Submit Patch"
b) after "Submit Patch"
c) either before or after ?

On Apr 16, 2007, at 1:31 PM, Tom White (JIRA) wrote:


[ https://issues.apache.org/jira/browse/HADOOP-1260? page=com.atlassian.jira.plugin.system.issuetabpanels:comment- tabpanel#action_12489223 ]

Tom White commented on HADOOP-1260:
-----------------------------------

+1

need code review guidelines
---------------------------

                Key: HADOOP-1260
URL: https://issues.apache.org/jira/browse/ HADOOP-1260
            Project: Hadoop
         Issue Type: Improvement
         Components: build
           Reporter: Nigel Daley

Following the improvements to the Hadoop release process (HADOOP-1161), it would be helpful to better document what a code review should entail. I've posted a proposal here (not yet linked to from anywhere):
http://wiki.apache.org/lucene-hadoop/CodeReviewChecklist
Thoughts?

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Reply via email to