Yes, I think we should fix the metrics code to make the thread a daemon
- others will forget or fail to call stopMonitoring (or close) on the
MetricsContext.

That said, it is good to close the MetricsContext also.  If the process
is about to terminate it doesn't really matter, but this will in general
free up some resources.

I got a bit confused here because the version of the patch with the
reindentation shows up as the latest, but it doesn't have the metrics fix.


Reply via email to