[
https://issues.apache.org/jira/browse/HADOOP-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Cutting updated HADOOP-1148:
---------------------------------
Attachment: checkstyle-errors.html
whitespace.patch
There were some problems with my earlier Emacs indentation scripting. It
missed files that define multiple classes, and sometimes mis-indented methods
with annotations.
I also:
- modified checkstyle's case indentation rule to use Sun's conventions;
- disabled checkstyle for JavaCC-generated files
- removed spaces before and after parens
- removed spaces before semicolons
- added spaces after commas
The number of checkstyle warnings are now radically reduced, with very few now
that can be fixed by changing spacing alone (so that patches survive).
1115 Line is longer than 80 characters.
474 First sentence should end with a period.
414 'if' construct must use '{}'s.
215 Redundant 'public' modifier.
135 Array brackets at illegal position.
117 Line contains a tab character.
116 Must have at least one statement.
101 ',' is not followed by whitespace.
56 '}' should be on the same line.
40 '{' should be on the previous line.
38 ';' is not followed by whitespace.
34 'else' construct must use '{}'s.
33 'private' modifier out of order with the JLS suggestions.
28 '(' should be on the previous line.
27 'static' modifier out of order with the JLS suggestions.
24 Utility classes should not have a public or default constructor.
23 '{' is followed by whitespace.
22 'name' hides a field.
21 'for' construct must use '{}'s.
20 Inner assignments should be avoided.
Should I commit this?
> re-indent all code
> ------------------
>
> Key: HADOOP-1148
> URL: https://issues.apache.org/jira/browse/HADOOP-1148
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Doug Cutting
> Assigned To: Doug Cutting
> Priority: Minor
> Fix For: 0.13.0
>
> Attachments: checkstyle-errors.html, indents2.patch, whitespace.patch
>
>
> We should re-indent all code to consistently use 2-spaces per level. This
> will not invalidate outstanding patches: one can use the '-l' option to
> ignore whitespace differences in patches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
