[
https://issues.apache.org/jira/browse/HADOOP-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12491456
]
Konstantin Shvachko commented on HADOOP-1272:
---------------------------------------------
- removeNeededReplications
should take 2 more parameters rather than recalculating them
does not need to be synchronized
- updateNeededReplications
should take new and old replications rather than deltas
should not recalculate replication if it is already known
- I don't think there is a need for removeNeededReplications and
updateNeededReplications
One can just use neededReplications.remove and neededReplications.update
the way it used to be.
- UnderReplicatedBlocks:
3 import warnings
- SafeModeInfo
2 import warnings
I really didn't like how the code got more complicated, because you need to
startSafeModeMonitor()
in 3 places rather than one, and stateChangeLog() is printing only in one place
instead of 3.
I'd just keep SafeModeInfo as an inner class.
- FileUnderConstruction
1 import warning
- Import warnings all new files.
- Why GetImageServlet and FsckServlet are not separated?
I thought nobody argued about keeping them inner as long as they are in the
same package.
> Extract InnerClasses from FSNamesystem into separate classes
> ------------------------------------------------------------
>
> Key: HADOOP-1272
> URL: https://issues.apache.org/jira/browse/HADOOP-1272
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Reporter: dhruba borthakur
> Assigned To: dhruba borthakur
> Attachments: innerclasses2.patch
>
>
> This will make the code cleaner. Also, it leads itself to a cleaner and
> easily understandable finer-grain locking model.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
