[
https://issues.apache.org/jira/browse/HADOOP-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495181
]
Doug Cutting commented on HADOOP-1298:
--------------------------------------
This is looking pretty good. A few quick, mostly minor, comments:
0. You forgot to include Users.java.
1. FileStatus constructor javadoc example should use "0777" instead of "777".
2. FileStatus getters need javadoc comments.
3. Javadoc comments should start with a correctly punctuated sentence.
4. Commented-out code in FileSystem.java should be removed.
5. Whitespace-only changes should be removed.
6. Permissions should be package-private, not public.
I've still not closely examined the DFS-internal changes. Konstantin, Dhruba,
can you please look this over again when you have a chance? Thanks.
> adding user info to file
> ------------------------
>
> Key: HADOOP-1298
> URL: https://issues.apache.org/jira/browse/HADOOP-1298
> Project: Hadoop
> Issue Type: New Feature
> Components: dfs, fs
> Reporter: Kurtis Heimerl
> Attachments: hadoop-user-munncha.patch, hadoop-user-munncha.patch,
> hadoop-user-munncha.patch, hadoop-user-munncha.patch10,
> hadoop-user-munncha.patch11, hadoop-user-munncha.patch12,
> hadoop-user-munncha.patch13, hadoop-user-munncha.patch4,
> hadoop-user-munncha.patch5, hadoop-user-munncha.patch6,
> hadoop-user-munncha.patch7, hadoop-user-munncha.patch8,
> hadoop-user-munncha.patch9
>
>
> I'm working on adding a permissions model to hadoop's DFS. The first step is
> this change, which associates user info with files. Following this I'll
> assoicate permissions info, then block methods based on that user info, then
> authorization of the user info.
> So, right now i've implemented adding user info to files. I'm looking for
> feedback before I clean this up and make it offical.
> I wasn't sure what release, i'm working off trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
