[ 
https://issues.apache.org/jira/browse/HADOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498733
 ] 

stack commented on HADOOP-1375:
-------------------------------

Regards your patch:

+ it has some pollution:

patching file 
src/contrib/hbase/src/java/org/apache/hadoop/hbase/shell/engine/Test.java
patching file 
src/contrib/hbase/src/java/org/apache/hadoop/hbase/shell/engine/TestInputFormat.java
patching file 
src/contrib/hbase/src/java/org/apache/hadoop/hbase/shell/maths/Hypotenuse.java

+ scan still requires a 'where' specifying a row:

HBase > tables;
Total tables : 1
 test
HBase > scan test;
Exception in thread "main" org.apache.hadoop.hbase.shell.ParseException: 
Encountered ";\n" at line 3, column 10.
Was expecting:
    <WHERE> ...
    
        at 
org.apache.hadoop.hbase.shell.HBaseShell.generateParseException(HBaseShell.java:568)
        at 
org.apache.hadoop.hbase.shell.HBaseShell.jj_consume_token(HBaseShell.java:507)
        at org.apache.hadoop.hbase.shell.HBaseShell.parse(HBaseShell.java:139)
        at org.apache.hadoop.hbase.shell.HBaseShell.main(HBaseShell.java:50)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.apache.hadoop.util.RunJar.main(RunJar.java:155)

+ What else did this new patch add?  I'd suggest that when you upload a new 
patch that you add description about what the new version adds.  It'll help me 
figure what to test.

> a simple parser for hbase.
> --------------------------
>
>                 Key: HADOOP-1375
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1375
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>         Environment: All environments 
>            Reporter: udanax
>            Priority: Minor
>         Attachments: patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, 
> patch.txt, patch.txt
>
>
> this is a simple parser for hbase test.
> i just write it.
> you can use this syntax to create and set.
> {code}
> [# [EMAIL PROTECTED] ./bin/hadoop jar ./build/hadoop-hbase 
> org.apache.hadoop.hbase.parser.HbaseParser
> Hbase > help;
> blah blah...
> Hbase > build webtable columnfamilies('anchors', 'language') limit=3;
> Hbase > set webtable values('anchors:http://www.udanax.org/','opensource') 
> where row="http://www.hadoop.co.kr";;
> Hbase > scan webtable where row="http://www.hadoop.co.kr";;
> blah blah...
> Hbase > set webtable values('language:kr','euc-kr') where 
> row="http://www.hadoop.co.kr";;
> Hbase > scan webtable where row="http://www.hadoop.co.kr"; and 
> column="language:kr";
> blah blah...
> Hbase > exit
> [# [EMAIL PROTECTED] 
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to