[
https://issues.apache.org/jira/browse/HADOOP-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501304
]
David Bowen commented on HADOOP-1446:
-------------------------------------
The changes look correct, but I don't like the change to TaskRunner, the adding
of synchronization on the TaskTracker object:
synchronized (tracker) {
vargs.add(tracker.taskReportPort + ""); // pass umbilical port
}
I think it would be much better to add a synchronized getTaskReportPort method
to TaskTracker and make the taskReportPort field private.
> Metrics from the TaskTracker are updated only when map/reduce tasks
> start/end/fail
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-1446
> URL: https://issues.apache.org/jira/browse/HADOOP-1446
> Project: Hadoop
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.12.3
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.14.0
>
> Attachments: 1446.patch, 1446.patch
>
>
> Metrics reporting from the TaskTracker for the maps_running and
> reduces_running metrics are done only when a task is starting up or finishing
> up. This is wrong and the metrics reporting should be done periodically
> during the life of the TaskTracker just as it is done for the JobTracker case.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
