[
https://issues.apache.org/jira/browse/HADOOP-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506705
]
stack commented on HADOOP-1375:
-------------------------------
Looking more at the patch. You need to remove the tabs and instead use spaces,
two per tabstop. Also, check out the sun coding conventions and study hadoop
code. See how it does spacings around brackets in particular (You tend to have
none whereas hadoop code has one space). Given the issues outlined above, I'd
suggest adding unit tests -- at least for the content of your cmd subpackage.
Have your unit tests pass odd parameters and see how your parse handles them.
> a simple parser for hbase.
> --------------------------
>
> Key: HADOOP-1375
> URL: https://issues.apache.org/jira/browse/HADOOP-1375
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Environment: All environments
> Reporter: udanax
> Priority: Minor
> Attachments: hadoop1375-v12.patch, jline-0.9.91.jar, patch.txt,
> patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt, patch.txt,
> patch.txt, patch.txt, patch.txt
>
>
> http://wiki.apache.org/lucene-hadoop/HbaseShell (work in progress)
> HBase Shell is developed to achieve the following goals.
> * Generic Monitoring Function
> * A Simplified Import/Export/Migrate Functionality Between different data
> sources (Hadoop, HBase)
> * A Simplified processing of a logical data model
> * A Simplified algebraic operations
> (Parallel Numerical Analysis by abstracting/numericalizing points, lines,
> or plane data across multiple maps in HBase.)
> {code}
> [# [EMAIL PROTECTED] ./bin/hadoop jar ./build/hadoop-hbase
> org.apache.hadoop.hbase.shell.HbaseShell
> Hbase > help;
> blah blah...
> Hbase > create webtable
> --> columnfamilies('anchors', 'language') limit=3;
> Hbase > set webtable values('anchors:http://www.udanax.org/','opensource')
> where row="http://www.hadoop.co.kr";;
> Hbase > scan webtable where row="http://www.hadoop.co.kr";;
> blah blah...
> Hbase > set webtable values('language:kr','euc-kr') where
> row="http://www.hadoop.co.kr";;
> Hbase > scan webtable where row="http://www.hadoop.co.kr"; and
> column="language:kr";
> blah blah...
> Hbase > scan webtable;
> Hbase > exit
> [# [EMAIL PROTECTED]
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
