[
https://issues.apache.org/jira/browse/HADOOP-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507522
]
stack commented on HADOOP-1509:
-------------------------------
I like the way you convert comments to javadoc when method goes from private to
protected and thanks for adding the missing version check when going to a new
region server.
One question. Why make RegionLocation and HRegionInfo mutable? And
HRegion.localput probably shouldn't be public?
The patch didn't apply cleanly for me. HClient has changed since your add of
v3 to this issue.
> Open HRegionServer/HClient for extension
> ----------------------------------------
>
> Key: HADOOP-1509
> URL: https://issues.apache.org/jira/browse/HADOOP-1509
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Affects Versions: 0.14.0
> Reporter: James Kennedy
> Assignee: James Kennedy
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: openForExtension-v2.patch, openForExtension-v3.patch,
> openForExtension.patch
>
>
> For what i'm doing I found it necessary to extend
> HRegionServer/HRegion/HClient for some custom functionality.
> Following good Java practice I see that the HBase code as been programmed
> defensively, keeping stuff private as much as possible.
> However, for extensibility it would be nice if the servers/client were easy
> to extend.
> Attached is a patch that makes several methods protected instead of private,
> adds getters to fields of inner classes, and some other modifications i found
> were useful for some simple extension code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
