[
https://issues.apache.org/jira/browse/HADOOP-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508295
]
David Bowen commented on HADOOP-1485:
-------------------------------------
+1. Code reviewed.
A small point: in the TaskTracker constructor, it would be preferable to
initialize the workerThreads field before the shuffleServerMetrics field, since
the call-back to ShufflerServerMetrics.doUpdates could otherwise occur before
workerThreads is initialized. I don't think that this would do any harm as the
code stands, but generally speaking it would be better to not register the
callback until the TaskTracker instance is otherwise initialized to reduce the
likelihood of future bugs.
> Metrics should be there for reporting shuffle failures/successes
> ----------------------------------------------------------------
>
> Key: HADOOP-1485
> URL: https://issues.apache.org/jira/browse/HADOOP-1485
> Project: Hadoop
> Issue Type: Improvement
> Components: mapred
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.14.0
>
> Attachments: 1485.1.patch, 1485.1.patch, shuffle-metrics.patch
>
>
> It would be nice to have metrics for the shuffle phase which reports the
> failures/successes for the fetches. This would aid in performance tests and
> in debugging (shuffle).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
