[ 
https://issues.apache.org/jira/browse/HADOOP-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513148
 ] 

Hadoop QA commented on HADOOP-1615:
-----------------------------------

-1, build or testing failed

2 attempts failed to build and test the latest attachment 
http://issues.apache.org/jira/secure/attachment/12361939/patch.txt against 
trunk revision r556754.

Test results:   
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/425/testReport/
Console output: 
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/425/console

Please note that this message is automatically generated and may represent a 
problem with the automation system and not the patch.

> Replacing thread notification-based queue with 
> java.util.concurrent.BlockingQueue in HMaster
> --------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-1615
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1615
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: contrib/hbase
>    Affects Versions: 0.13.0
>            Reporter: Steve Jenson
>            Assignee: Jim Kellerman
>            Priority: Trivial
>             Fix For: 0.13.0
>
>         Attachments: HADOOP-1615.patch, patch.txt, patch.txt
>
>
> In HMaster, there is a msgQueue typed as an ArrayList<PendingOperations>. 
> PendingOperations are added to the queue and notify() is called on msgQueue. 
> I think using a BlockingQueue<PendingOperations> makes the intent of the code 
> more clear and removes potentially problematic synchronization issues. 
> BlockingQueues are thread-safe and allow multiple producers and consumers. I 
> have written a patch for this and will attach it. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to