[
https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515806
]
Tsz Wo (Nicholas), SZE commented on HADOOP-1653:
------------------------------------------------
+1 for fsdirectory-cleanup-20070725-1706.patch
Codes look good.
Chiristophe, the issue of changing UTF8 in FSEditLog is not that simple since
some other part of the system will read the log file. If we only change here,
then the reading part might not work. I am sorry for asking you to do so.
> FSDirectory class code cleanup
> ------------------------------
>
> Key: HADOOP-1653
> URL: https://issues.apache.org/jira/browse/HADOOP-1653
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Affects Versions: 0.15.0
> Reporter: Christophe Taton
> Priority: Trivial
> Attachments: fsdirectory-cleanup-20070725-1706.patch,
> fsdirectory-cleanup-20070725-1939.patch,
> fsdirectory-cleanup-20070725-2005.patch
>
>
> - lets FSDirectory.INode become a static class, thus sparing one pointer per
> INode
> - removes an unused constructor for FSDirectory.INode
> - merges identical methods INode.getAbsoluteName() and INode.computeName()
> and optimizes it using StringBuffer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
