[ 
https://issues.apache.org/jira/browse/HADOOP-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christophe Taton updated HADOOP-1653:
-------------------------------------

    Attachment: fsdirectory-cleanup-20070725-2005.patch
                fsdirectory-cleanup-20070725-1939.patch

Here are 2 differents patches:
 - fsdirectory-cleanup-20070725-1939.patch (~370 lines) removes all references 
to UTF8 in FSEditLog. I submit it also as I created and tested it before your 
answer;
 - fsdirectory-cleanup-20070725-2005.patch (~250 lines) removes references to 
UTF8 in FSEditLog for the methods logCreateFile(), logMkDir() and update their 
symmetric in loadFSEdits().

Both pass all JUnit tests. Choose the one you prefer.

Christophe T.

> FSDirectory class code cleanup
> ------------------------------
>
>                 Key: HADOOP-1653
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1653
>             Project: Hadoop
>          Issue Type: Improvement
>          Components: dfs
>    Affects Versions: 0.15.0
>            Reporter: Christophe Taton
>            Priority: Trivial
>         Attachments: fsdirectory-cleanup-20070725-1706.patch, 
> fsdirectory-cleanup-20070725-1939.patch, 
> fsdirectory-cleanup-20070725-2005.patch
>
>
>  - lets FSDirectory.INode become a static class, thus sparing one pointer per 
> INode
>  - removes an unused constructor for FSDirectory.INode
>  - merges identical methods INode.getAbsoluteName() and INode.computeName() 
> and optimizes it using StringBuffer

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to