On Aug 10, 2007, at 2:51 PM, Doug Cutting wrote:
Nigel Daley wrote:
The Hadoop nightly build uses the src/test/checkstyle.xml as
expected, but the patch process copies in a custom version of both
the xml and xsl. The custom version only has the following rules
enabled since that is all we've cleaned up in the code base.
<module name="Indentation">
<property name="basicOffset" value="2" />
<property name="caseIndent" value="2" />
</module>
Should we check these into subversion so that folks can more easily
replicate what Hudson does?
Doug
Sure, once Hudson actually takes action based on the checkstyle
results. As I said in my email:
"Even with just these 2 rules enabled there are lots of warnings so I
haven't yet gone the extra step to fail a patch build if these rules
are violated."
There needs to be more discussion on how to integrate checkstyle so
that the results are understandable and fixable if a patch is -1'd.
Right now I believe there are on the order of a 1000 warnings from
the tool with just these 2 rules. That's too many to make this useful.
See this for an example:
<http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/507/
artifact/trunk/build/test/checkstyle-errors.html>
Cheers,
Nige
