[
https://issues.apache.org/jira/browse/HADOOP-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524633
]
Owen O'Malley commented on HADOOP-1826:
---------------------------------------
It is a real problem for ant. (ie. Ant can get itself into states where only a
clean and rebuild will work.) I have seen the same problem in Eclipse...
However, my primary goal is for me to be able to find the code. I think either
non-public classes in their own files or static inner classes are better
choices than hiding a class in a non-obvious place.
> Side classes should be moved to separate files
> ----------------------------------------------
>
> Key: HADOOP-1826
> URL: https://issues.apache.org/jira/browse/HADOOP-1826
> Project: Hadoop
> Issue Type: Improvement
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.15.0
>
>
> The following classes are "side" classes that aren't in files with the same
> name. This caused problems last night because ant compiled things in the
> wrong order and couldn't find one of the relevant classes. I think it would
> make the code easier to read and understand if you could always find a given
> class in the expected place.
> {code}
> > find src/java -name '*.java' | xargs grep '^class' | sed -e
> > 's|\([a-zA-Z0-9/]*/\)\([^/.]*\)[.]java:class \([^ <]*\).*|\1 \2 \3|' | awk
> > '{if ($2 != $3) print $1$2".java",$3}'
> src/java/org/apache/hadoop/mapred/BasicTypeSorterBase.java
> MRSortResultIterator
> src/java/org/apache/hadoop/dfs/BlockCommand.java DatanodeCommand
> src/java/org/apache/hadoop/dfs/Storage.java StorageInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java DNBlockUpgradeInfo
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java BlockCrcUpgradeUtils
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java
> BlockCrcUpgradeObjectDatanode
> src/java/org/apache/hadoop/dfs/BlockCrcUpgrade.java
> BlockCrcUpgradeObjectNamenode
> src/java/org/apache/hadoop/dfs/INode.java INodeDirectory
> src/java/org/apache/hadoop/dfs/INode.java INodeFile
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
