Any objections to committing contrib patches if +1 on everything but
'core tests'?
Otherwise, looks good to me.
St.Ack
Nigel Daley wrote:
All,
I'm ready to deploy a new and improved patch process build script for
our Hadoop-Patch builds. It will comment on all issues at once.
Here's an example comment:
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12365627/HADOOP-1879_2.patch
against trunk revision r575188.
@author +1. The patch contains no @author tags.
javadoc +1. The javadoc tool appears to have generated no
warning messages.
javac +1. The patch did not generate any new compiler warnings.
findbugs +1. The patch did not generate any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/751/testReport/
Findbugs warnings:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/751/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/751/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/751/console
This message is automatically generated.
As you can see, it separates contrib testing from core testing. Also,
it will only attempt a single run of the tests (it used to run them a
2nd time if any failed the first time). This should help shorten the
length of time the build takes to run. A -1 on any check will give a
-1 overall.
Does this look good to people?
Thanks,
Nige
