[ 
https://issues.apache.org/jira/browse/HADOOP-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527477
 ] 

Enis Soztutar commented on HADOOP-1894:
---------------------------------------

bq. 1) changing order of import statements is unneccessary
The patch remove imports ending with *  and puts actual class names.
bq. 2) several whitespace changes made it into this patch - on purpose?
I do not like whitespace-only changes, They occur because the line contain some 
whitespace, and in the development process, they are removed. Although we do 
not like them, it is not a strict policy of hadoop. 
bq. 3) what is "serialVersionUID"? it's set but never used, from what i can 
tell.
Serializable classes should have a serialVersionUID. see the javadoc for 
further info

> Add fancy graphs for mapred task statuses
> -----------------------------------------
>
>                 Key: HADOOP-1894
>                 URL: https://issues.apache.org/jira/browse/HADOOP-1894
>             Project: Hadoop
>          Issue Type: New Feature
>          Components: mapred
>    Affects Versions: 0.15.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 0.15.0
>
>         Attachments: fancygraph_v1.0.patch, mapreduce.png, percentage.png
>
>
> I whould like to add graphics for mapred task statuses. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to