[
https://issues.apache.org/jira/browse/HADOOP-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530178
]
dhruba borthakur commented on HADOOP-1933:
------------------------------------------
Code looks good. One minor comment: in one place a DatanodeDescriptor is
created for a dead node with port 50075. Since these are deadnodes that have
never tried to connect to the namenode, would it be better to specify the port
as 0? This would mean that the namenode really does not know the port.
> Consider include/exclude files while listing datanodes.
> -------------------------------------------------------
>
> Key: HADOOP-1933
> URL: https://issues.apache.org/jira/browse/HADOOP-1933
> Project: Hadoop
> Issue Type: Improvement
> Components: dfs
> Reporter: Raghu Angadi
> Assignee: Raghu Angadi
> Attachments: HADOOP-1933.patch
>
>
> While listing datanodes (e.g. in webui), consider the nodes listed in include
> and exclude files.
> Proposed Rules :
> # If a node is listed in include file, it should be listed
> # If a node is listed under exclude file, it should not be listed unless it
> is not 'dead'.
> Dhruba implies only the first rule applies towards the end of HADOOP-1138,
> i.e., a node should be listed if it exists either of the files. Dhruba,
> please clarify.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
