[
https://issues.apache.org/jira/browse/HADOOP-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532574
]
Vivek Ratan commented on HADOOP-1994:
-------------------------------------
I think a prefix more complicated than an underscore is better. The prefix is
used in generated code, which presumably the user will never want to go through
if everything works well. So readability of code is not a big issue. Why, then,
restrict the user to not using fields starting with an underscore? It seems
like too harsh a restriction. It's much better to tell them to not have fields
starting with <underscore>rio<underscore> than just an underscore.
Regarding enforcing, I think that's a good idea. We can have the DDL complier
do that.
> Variable names generated by Record I/O should not clash with user fields
> ------------------------------------------------------------------------
>
> Key: HADOOP-1994
> URL: https://issues.apache.org/jira/browse/HADOOP-1994
> Project: Hadoop
> Issue Type: Bug
> Reporter: Vivek Ratan
> Assignee: Vivek Ratan
>
> The code (Java and C++) spit out by the Record I/O compiler contains
> variables. We need to make sure these variable names don't clash with names
> used by users in the DDL, otherwise the generated code will not compile.
> Variable names such as 'a', 'peer', etc, are used. We need better names. For
> example, if I have a DDL of the form
> {code}
> class s1 {
> int a;
> boolean peer;
> int a_;
> }
> {code}
> Both the Java and C++ code will not compile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
