[
https://issues.apache.org/jira/browse/HADOOP-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534451
]
Hadoop QA commented on HADOOP-1130:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12367666/1130.patch
against trunk revision r584286.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/939/testReport/
Findbugs warnings:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/939/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/939/artifact/trunk/build/test/checkstyle-errors.html
Console output:
http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/939/console
This message is automatically generated.
> Remove unused ClientFinalizer in DFSClient
> ------------------------------------------
>
> Key: HADOOP-1130
> URL: https://issues.apache.org/jira/browse/HADOOP-1130
> Project: Hadoop
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.10.1, 0.11.0, 0.11.1, 0.11.2, 0.12.0
> Reporter: Philippe Gassmann
> Assignee: Chris Douglas
> Fix For: 0.16.0
>
> Attachments: 1130.patch, HADOOP-1130.diff
>
>
> The ClientFinalizer shutdown hook is not used.
> This can lead to severe memory leaks if you use the DFSClient in a dynamic
> class loading context (such as in a webapp) as the DFSClient.ClientFinalizer
> class is retained in the memory by the shutdown hook. It retains also the
> current ClassLoader and thus all classes loaded by the ClassLoader. (Threads
> put in the shutdown hook are never garbage collected).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
