I believe its already invoked as part of nightlies. Its called along the way making the tarball. Perhaps my JIRA description should have been better? The 'package' target already exists in main build.xml. This patch just 'forwards' responsibility for packaging contribs down to the contribs themselves giving them chance to customize how packaging is done if wanted (hbase at least needs it).

Good on you Nigel,
St.Ack


Nigel Daley wrote:
Hi stack,

I imagine this target should be added to our Hudson builds. Please ping me once this gets committed and I'll add it.

Cheers,
Nige

On Nov 14, 2007, at 4:36 PM, stack (JIRA) wrote:


[ https://issues.apache.org/jira/browse/HADOOP-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HADOOP-2207:
--------------------------

    Fix Version/s: 0.16.0
           Status: Patch Available  (was: Open)

Trying against hudson.

Add 'package' target to contrib/build-contrib.xml
-------------------------------------------------

                Key: HADOOP-2207
                URL: https://issues.apache.org/jira/browse/HADOOP-2207
            Project: Hadoop
         Issue Type: Improvement
           Reporter: stack
           Priority: Minor
            Fix For: 0.16.0

        Attachments: 2207.patch


Currently, contribs each build a jar file that is deployed to the contrib directory when hadoop is packaged. Here is a listing:
{code}
ls build/hadoop-0.16.0-dev/contrib/
hadoop-0.16.0-dev-abacus-examples.jar
hadoop-0.16.0-dev-abacus.jar
hadoop-0.16.0-dev-datajoin-examples.jar hadoop-0.16.0-dev-datajoin.jar
hadoop-0.16.0-dev-hbase.jar
hadoop-0.16.0-dev-streaming.jar
{code}
This works when the contrib product is a jar only.
The hbase contrib needs to add scripts, configurations and its own jar dependencies. HADOOP-1648 proposed amending the general cluster CLASSPATH to add contrib jars (contrib dependencies would be added to lib/contrib). HADOOP-2196 was proposing that hbase scripts be installed into the bin directory beside the hadoop core scripts. Discussion up on #hadoop IRC channel this morning came up w/ a solution that better keeps the separation between whats core and whats contrib. In synopsis, responsibility for the contrib packaging is passed down to contribs as a new target in build-contrib.xml. The default would build the jar as is done now only rather than package the jar under the contrib directory, instead, the contrib jar would be put into a subdirectory named for the contrib. So for hbase, instead of packaging the hbase jar at contrib/hadoop-X.X.X-hbase.jar, instead it would sit at contrib/hbase/hadoop-X.X.X-hbase.jar . Those contribs that comprise of more than just a jar product -- e.g. hbase with its start/stop scripts, dependent libraries and configurations -- on invocation of the 'package' target, would create a bin, lib, and conf directory inside contrib/hbase/.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Reply via email to