[
https://issues.apache.org/jira/browse/HADOOP-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajagopal Natarajan updated HADOOP-1347:
----------------------------------------
Attachment: unset_with_tests.patch
Hi Arun,
Thanks for the comments.
1. Indentation had been changed.
2. Say, there is an optional parameter that has been set in the default
configuration or site configuration, and the user wants to remove that, unset
could be useful instead of leaving the property name in properties list and
having a null there. By the default conf reading logic used in the program, if
either attr or value were null while reading initially, the property isn't
added to properties. Similarly, if at a later point, the value would be null,
it sounds logical for me to remove the property. Please correct me if I'm wrong.
3. A Test Case has been added.
> Configuration XML bug: empty values
> -----------------------------------
>
> Key: HADOOP-1347
> URL: https://issues.apache.org/jira/browse/HADOOP-1347
> Project: Hadoop
> Issue Type: Bug
> Components: conf
> Reporter: Eelco Lempsink
> Assignee: Rajagopal Natarajan
> Priority: Critical
> Attachments: unset.patch, unset_with_tests.patch
>
>
> The configuration parser doesn't handle empty values well:
> if ("value".equals(field.getTagName()) && field.hasChildNodes())
> This logic makes it impossible to 'unset' a field when loading multiple
> configurations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
