[ 
https://issues.apache.org/jira/browse/HADOOP-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12545345
 ] 

Nigel Daley commented on HADOOP-2272:
-------------------------------------

[Sorry for slow response...on vacation]

The reason this patch still fails is that the patch process runs findbugs 
before applying the patch and then again after applying the patch so that a 
diff can be determined.  Running findbugs before the patch is applied is broken 
since we need this patch to fix findbugs.  I'll commit this patch.

I've also updated the patch script so that a failure of findbugs like that 
caused by HADOOP-2207 will cause a -1 comment.

If other contrib components would like findbugs run on them, then please add 
them to build.xml.

> findbugs currently fails due to hadoop-streaming having moved
> -------------------------------------------------------------
>
>                 Key: HADOOP-2272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2272
>             Project: Hadoop
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.15.0
>            Reporter: Adrian Woodhead
>            Assignee: stack
>         Attachments: HADOOP-2272-1.patch
>
>
> If you do a fresh checkout of the trunk and try run findbugs you get the 
> following error:
> findbugs:
>  [findbugs] Running FindBugs...
>  [findbugs] Exception in thread "main" java.util.zip.ZipException: Error 
> opening /tmp/x/trunk/build/hadoop-0.16.0-dev-streaming.jar
>  [findbugs]     at 
> edu.umd.cs.findbugs.classfile.impl.ZipFileCodeBase.<init>(ZipFileCodeBase.java:61)
>  [findbugs]     at 
> edu.umd.cs.findbugs.classfile.impl.ClassFactory.createFilesystemCodeBase(ClassFactory.java:96)
>  [findbugs]     at 
> edu.umd.cs.findbugs.classfile.impl.FilesystemCodeBaseLocator.openCodeBase(FilesystemCodeBaseLocator.java:63)
>  [findbugs]     at 
> edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.processWorkList(ClassPathBuilder.java:381)
>  [findbugs]     at 
> edu.umd.cs.findbugs.classfile.impl.ClassPathBuilder.build(ClassPathBuilder.java:192)
>  [findbugs]     at 
> edu.umd.cs.findbugs.FindBugs2.buildClassPath(FindBugs2.java:432)
>  [findbugs]     at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:160)
>  [findbugs]     at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:1521)
>  [findbugs]     at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:731)
>  [findbugs] Output saved to 
> /tmp/x/trunk/build/test/findbugs/hadoop-findbugs-report.xml
>      [xslt] Processing 
> /tmp/x/trunk/build/test/findbugs/hadoop-findbugs-report.xml to 
> /tmp/x/trunk/build/test/findbugs/hadoop-findbugs-report.html
>      [xslt] Loading stylesheet /opt/java/findbugs/src/xsl/default.xsl
>      [xslt] : Error! Premature end of file.
>      [xslt] : Error! 
> com.sun.org.apache.xml.internal.utils.WrappedRuntimeException: Premature end 
> of file.
>      [xslt] Failed to process 
> /tmp/x/trunk/build/test/findbugs/hadoop-findbugs-report.xml
> BUILD FAILED
> /tmp/x/trunk/build.xml:599: javax.xml.transform.TransformerException: 
> javax.xml.transform.TransformerException: 
> com.sun.org.apache.xml.internal.utils.WrappedRuntimeException: Premature end 
> of file.
> ----
> This is because 
> build/hadoop-0.16.0-dev-streaming.jar 
> is the wrong location, it should be 
> build/contrib/streaming/hadoop-0.16.0-dev-streaming.jar 
> I think this also explains why Hudson is currently giving a -1 to all new 
> patches as findbugs is failing.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to